This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Makefiles now check for virtualenv and pkg-config. #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Milind for trying neon! http://neon.nervanasys.com/docs/2.0.0/installation.html indeed shows both virtualenv and pkg-config as pre-requisites. But you have done more to let users know this easily and avoid having to go to the page which the user might not be aware of. Your change is very helpful, thank you! We will make sure we integrate your PR in our next release. |
clrpackages
pushed a commit
to clearlinux-pkgs/neon
that referenced
this pull request
Aug 7, 2017
## v2.1.0 (2017-08-02): * Set MKL backend (-b mkl) as the default CPU backend on Linux (use -b cpu to specify original CPU backend) * Update MKLML version 20170720 (AVX512 code paths enabled by default and conversion optimizations) * Simplify ResNet example * Makefiles now check for virtualenv and pkg-config (NervanaSystems/neon#383) * Fix Deep Speech2 model on MKL backend * Fix MKL installation for "make sysinstall"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing Neon on a brand-new MacBook Pro running OS X Sierra, I encountered an absence of pkg-config as well as virtualenv. I added checks and error messages to appropriate Makefiles to cover these cases.