Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change docker compose workflow to not require tar.gz download #1505

Closed
cgrinds opened this issue Nov 17, 2022 · 8 comments · Fixed by #2046, #2354 or #2436
Closed

Change docker compose workflow to not require tar.gz download #1505

cgrinds opened this issue Nov 17, 2022 · 8 comments · Fixed by #2046, #2354 or #2436
Assignees
Labels
23.11 feature New feature or request status/done

Comments

@cgrinds
Copy link
Collaborator

cgrinds commented Nov 17, 2022

No description provided.

@cgrinds
Copy link
Collaborator Author

cgrinds commented Feb 8, 2023

We investigated this and nothing to pursue right now. Closing

@cgrinds
Copy link
Collaborator Author

cgrinds commented Feb 9, 2023

Investigate if this can be improved in 23.05

@cgrinds cgrinds reopened this Feb 9, 2023
@rahulguptajss rahulguptajss self-assigned this Apr 24, 2023
@rahulguptajss rahulguptajss added 23.08 and removed 23.05 labels Apr 26, 2023
@rahulguptajss rahulguptajss removed their assignment Aug 3, 2023
@rahulguptajss rahulguptajss added 23.11 and removed 23.08 labels Aug 3, 2023
@rahulguptajss
Copy link
Contributor

Moving to next release. For this release we made improvements via #2046

@rahulguptajss
Copy link
Contributor

Assigning to myself for relevant changes.

@rahulguptajss
Copy link
Contributor

  • Code Changes
  • Documentation
  • Updated CI/CD to use the documented commands

@rahulguptajss rahulguptajss removed their assignment Nov 6, 2023
@Hardikl Hardikl self-assigned this Nov 9, 2023
@Hardikl
Copy link
Contributor

Hardikl commented Nov 9, 2023

Tested with nightly image. Case 2 is failing so re-opening the issue.

case1 : with harvest.yml in current folder

root@localhost:~/dockertest# pwd
/root/dockertest
root@localhost:~/dockertest# ls -ltr
total 4
-rw-r--r-- 1 root root 1562 Nov  9 03:11 harvest.yml
root@localhost:~/dockertest# docker run --rm \
>   --entrypoint "bin/harvest" \
>   --volume "$(pwd):/opt/temp" \
>   --volume "$(pwd)/harvest.yml:/opt/harvest/harvest.yml" \
>   ghcr.io/netapp/harvest:nightly \
>   generate docker full \
>   --output harvest-compose.yml
Unable to find image 'ghcr.io/netapp/harvest:nightly' locally
nightly: Pulling from netapp/harvest
63b450eae87c: Pull complete 
960043b8858c: Pull complete 
b4ca4c215f48: Pull complete 
eebb06941f3e: Pull complete 
02cd68c0cbf6: Pull complete 
d3c894b5b2b0: Pull complete 
b40161cd83fc: Pull complete 
46ba3f23f1d3: Pull complete 
4fa131a1b726: Pull complete 
4a2d7bc46f58: Pull complete 
f826710fbc51: Pull complete 
Digest: sha256:c05ca3d24b9afb7efbf3eeb2ff32ef3813df98524a5fc9b4494491d4085783f9
Status: Downloaded newer image for ghcr.io/netapp/harvest:nightly
Wrote file_sd targets to container/prometheus/harvest_targets.yml
Start containers with:
docker-compose -f prom-stack.yml -f harvest-compose.yml up -d --remove-orphans
root@localhost:~/dockertest# ls -ltr
total 28
-rw-r--r--  1 root root 1562 Nov  9 03:11 harvest.yml
drwxr-x---  2 root root 4096 Nov  9 03:12 cert
drwxr-x--- 10 root root 4096 Nov  9 03:12 conf
drwxr-xr-x  3 root root 4096 Nov  9 03:12 container
-rw-------  1 root root 1529 Nov  9 03:12 prom-stack.yml
-rw-------  1 root root 1881 Nov  9 03:12 harvest-compose.yml
drwxr-x---  4 root root 4096 Nov  9 03:12 grafana
root@localhost:~/dockertest# docker-compose -f prom-stack.yml -f harvest-compose.yml up -d --remove-orphans
Creating network "harvest_backend" with the default driver
Creating network "harvest_frontend" with the default driver
Creating volume "harvest_prometheus_data" with default driver
Creating volume "harvest_grafana_data" with default driver
Pulling umeng-aff300 (ghcr.io/netapp/harvest:latest)...
latest: Pulling from netapp/harvest
dd5ad9c9c29f: Pull complete
960043b8858c: Pull complete
b4ca4c215f48: Pull complete
eebb06941f3e: Pull complete
02cd68c0cbf6: Pull complete
d3c894b5b2b0: Pull complete
b40161cd83fc: Pull complete
46ba3f23f1d3: Pull complete
4fa131a1b726: Pull complete
4a2d7bc46f58: Pull complete
905eaa3efc35: Pull complete
Digest: sha256:f21e787bd33e885bd1fb3180496e1755271601df43f47da19b69ed9e3cc6d06d
Status: Downloaded newer image for ghcr.io/netapp/harvest:latest
Pulling prometheus (prom/prometheus:v2.33.1)...
v2.33.1: Pulling from prom/prometheus
3cb635b06aa2: Pull complete
34f699df6fe0: Pull complete
55d40b50ffc7: Pull complete
73fc1407aa37: Pull complete
28be42bd9809: Pull complete
16a1311431d0: Pull complete
6e6dfbb21ff4: Pull complete
cec290d8c550: Pull complete
3504f0a4fc48: Pull complete
459aec2a59be: Pull complete
838b4d86e3f3: Pull complete
6bb61ef5ec02: Pull complete
Digest: sha256:3a75763d209af6ef82aca8fb202a76092a690d25f24d2def7f4eff64e79b7ed9
Status: Downloaded newer image for prom/prometheus:v2.33.1
Pulling grafana (grafana/grafana:8.3.4)...
8.3.4: Pulling from grafana/grafana
59bf1c3509f3: Pull complete
dc6fd4c8b7cc: Pull complete
921cda16a84c: Pull complete
b2e847bc52f5: Pull complete
00a566fb83a4: Pull complete
a40995d122ce: Pull complete
dd54763fab15: Pull complete
e147c181ae77: Pull complete
cc6525936d2d: Pull complete
3cdad610e821: Pull complete
Digest: sha256:cf81d2c753c8d14cf0324d881e49f42d400347d256e473856e1bda02eb520a99
Status: Downloaded newer image for grafana/grafana:8.3.4
Creating poller-dc1          ... done
Creating poller-umeng-aff300 ... done
Creating poller-aff250       ... done
Creating poller-dc1-zapi     ... done
Creating poller-unix         ... done
Creating prometheus          ... done
Creating grafana             ... done
root@localhost:~/dockertest# docker ps
CONTAINER ID   IMAGE                           COMMAND                  CREATED         STATUS         PORTS                                           NAMES
888f1b72c675   grafana/grafana:8.3.4           "/run.sh"                3 seconds ago   Up 2 seconds   0.0.0.0:3000->3000/tcp, :::3000->3000/tcp       grafana
174e31c6347a   prom/prometheus:v2.33.1         "/bin/prometheus --c…"   8 seconds ago   Up 3 seconds   0.0.0.0:9090->9090/tcp, :::9090->9090/tcp       prometheus
31d0415007ef   ghcr.io/netapp/harvest:latest   "bin/poller --poller…"   8 seconds ago   Up 3 seconds   0.0.0.0:12992->12992/tcp, :::12992->12992/tcp   poller-unix
982cea9b2eaa   ghcr.io/netapp/harvest:latest   "bin/poller --poller…"   8 seconds ago   Up 4 seconds   0.0.0.0:12995->12995/tcp, :::12995->12995/tcp   poller-dc1-zapi
543823c3012e   ghcr.io/netapp/harvest:latest   "bin/poller --poller…"   8 seconds ago   Up 4 seconds   0.0.0.0:12994->12994/tcp, :::12994->12994/tcp   poller-dc1
150c39060971   ghcr.io/netapp/harvest:latest   "bin/poller --poller…"   8 seconds ago   Up 4 seconds   0.0.0.0:12990->12990/tcp, :::12990->12990/tcp   poller-umeng-aff300
a8a540e42e96   ghcr.io/netapp/harvest:latest   "bin/poller --poller…"   8 seconds ago   Up 4 seconds   0.0.0.0:12993->12993/tcp, :::12993->12993/tcp   poller-aff250

case2 : with harvest.yml in different folder

root@localhost:~/dockertest# pwd
/root/dockertest
root@localhost:~/dockertest# ls -ltr
total 0
root@localhost:~/dockertest# ls -ltr /root/harvestconfig/
total 4
-rw-r--r-- 1 root root 1562 Nov  9 03:00 harvest.yml
root@localhost:~/dockertest# HYML="/root/harvestconfig/harvest.yml" \
> docker run --rm \
> --entrypoint "bin/harvest" \
> --volume "$(pwd):/opt/temp" \
> --volume "${HYML}:${HYML}" \
> ghcr.io/netapp/harvest:nightly \
> generate docker full \
> --output harvest-compose.yml \
> --config "${HYML}"
Unable to find image 'ghcr.io/netapp/harvest:nightly' locally
nightly: Pulling from netapp/harvest
63b450eae87c: Pull complete 
960043b8858c: Pull complete 
b4ca4c215f48: Pull complete 
eebb06941f3e: Pull complete 
02cd68c0cbf6: Pull complete 
d3c894b5b2b0: Pull complete 
b40161cd83fc: Pull complete 
46ba3f23f1d3: Pull complete 
4fa131a1b726: Pull complete 
4a2d7bc46f58: Pull complete 
f826710fbc51: Pull complete 
Digest: sha256:c05ca3d24b9afb7efbf3eeb2ff32ef3813df98524a5fc9b4494491d4085783f9
Status: Downloaded newer image for ghcr.io/netapp/harvest:nightly
error reading  err=open : no such file or directory
root@localhost:~/dockertest# 

@Hardikl Hardikl reopened this Nov 9, 2023
@Hardikl Hardikl removed their assignment Nov 9, 2023
@rahulguptajss
Copy link
Contributor

@Hardikl Could you pls verify the failed step as mentioned in #2473

@Hardikl
Copy link
Contributor

Hardikl commented Nov 9, 2023

Tested with the steps mentioned in the PR #2473 , working as expected.

case2 : with harvest.yml in different folder

root@scspa2802353001:~/dockertest# pwd
/root/dockertest
root@scspa2802353001:~/dockertest# ls -ltr
total 0
root@scspa2802353001:~/dockertest# ls -ltr /root/harvestconfig/
total 4
-rw-r--r-- 1 root root 1562 Nov  9 03:00 harvest.yml
root@scspa2802353001:~/dockertest# HYML="/root/harvestconfig/harvest.yml"; \
> docker run --rm \
> --entrypoint "bin/harvest" \
> --volume "$(pwd):/opt/temp" \
> --volume "${HYML}:${HYML}" \
> ghcr.io/netapp/harvest:nightly \
> generate docker full \
> --output harvest-compose.yml \
> --config "${HYML}"
Unable to find image 'ghcr.io/netapp/harvest:nightly' locally
nightly: Pulling from netapp/harvest
63b450eae87c: Pull complete 
960043b8858c: Pull complete 
b4ca4c215f48: Pull complete 
eebb06941f3e: Pull complete 
02cd68c0cbf6: Pull complete 
d3c894b5b2b0: Pull complete 
b40161cd83fc: Pull complete 
46ba3f23f1d3: Pull complete 
4fa131a1b726: Pull complete 
4a2d7bc46f58: Pull complete 
f826710fbc51: Pull complete 
Digest: sha256:c05ca3d24b9afb7efbf3eeb2ff32ef3813df98524a5fc9b4494491d4085783f9
Status: Downloaded newer image for ghcr.io/netapp/harvest:nightly
Wrote file_sd targets to container/prometheus/harvest_targets.yml
Start containers with:
docker-compose -f prom-stack.yml -f harvest-compose.yml up -d --remove-orphans
root@scspa2802353001:~/dockertest# docker-compose -f prom-stack.yml -f harvest-compose.yml up -d --remove-orphans
Creating network "harvest_backend" with the default driver
Creating network "harvest_frontend" with the default driver
Creating volume "harvest_prometheus_data" with default driver
Creating volume "harvest_grafana_data" with default driver
Pulling umeng-aff300 (ghcr.io/netapp/harvest:latest)...
latest: Pulling from netapp/harvest
dd5ad9c9c29f: Pull complete
960043b8858c: Pull complete
b4ca4c215f48: Pull complete
eebb06941f3e: Pull complete
02cd68c0cbf6: Pull complete
d3c894b5b2b0: Pull complete
b40161cd83fc: Pull complete
46ba3f23f1d3: Pull complete
4fa131a1b726: Pull complete
4a2d7bc46f58: Pull complete
905eaa3efc35: Pull complete
Digest: sha256:f21e787bd33e885bd1fb3180496e1755271601df43f47da19b69ed9e3cc6d06d
Status: Downloaded newer image for ghcr.io/netapp/harvest:latest
Pulling prometheus (prom/prometheus:v2.33.1)...
v2.33.1: Pulling from prom/prometheus
3cb635b06aa2: Pull complete
34f699df6fe0: Pull complete
55d40b50ffc7: Pull complete
73fc1407aa37: Pull complete
28be42bd9809: Pull complete
16a1311431d0: Pull complete
6e6dfbb21ff4: Pull complete
cec290d8c550: Pull complete
3504f0a4fc48: Pull complete
459aec2a59be: Pull complete
838b4d86e3f3: Pull complete
6bb61ef5ec02: Pull complete
Digest: sha256:3a75763d209af6ef82aca8fb202a76092a690d25f24d2def7f4eff64e79b7ed9
Status: Downloaded newer image for prom/prometheus:v2.33.1
Pulling grafana (grafana/grafana:8.3.4)...
8.3.4: Pulling from grafana/grafana
59bf1c3509f3: Pull complete
dc6fd4c8b7cc: Pull complete
921cda16a84c: Pull complete
b2e847bc52f5: Pull complete
00a566fb83a4: Pull complete
a40995d122ce: Pull complete
dd54763fab15: Pull complete
e147c181ae77: Pull complete
cc6525936d2d: Pull complete
3cdad610e821: Pull complete
Digest: sha256:cf81d2c753c8d14cf0324d881e49f42d400347d256e473856e1bda02eb520a99
Status: Downloaded newer image for grafana/grafana:8.3.4
Creating poller-dc1-zapi     ... done
Creating poller-aff250       ... done
Creating poller-dc1          ... done
Creating prometheus          ... done
Creating poller-unix         ... done
Creating poller-umeng-aff300 ... done
Creating grafana             ... done
root@scspa2802353001:~/dockertest# docker ps
CONTAINER ID   IMAGE                           COMMAND                  CREATED         STATUS         PORTS                                           NAMES
3bec6bedc83d   grafana/grafana:8.3.4           "/run.sh"                4 seconds ago   Up 2 seconds   0.0.0.0:3000->3000/tcp, :::3000->3000/tcp       grafana
8a1428de0455   ghcr.io/netapp/harvest:latest   "bin/poller --poller…"   8 seconds ago   Up 3 seconds   0.0.0.0:12990->12990/tcp, :::12990->12990/tcp   poller-umeng-aff300
f686bf49c0d9   ghcr.io/netapp/harvest:latest   "bin/poller --poller…"   8 seconds ago   Up 3 seconds   0.0.0.0:12992->12992/tcp, :::12992->12992/tcp   poller-unix
abaebfc3f379   prom/prometheus:v2.33.1         "/bin/prometheus --c…"   8 seconds ago   Up 3 seconds   0.0.0.0:9090->9090/tcp, :::9090->9090/tcp       prometheus
7872c319fff4   ghcr.io/netapp/harvest:latest   "bin/poller --poller…"   8 seconds ago   Up 4 seconds   0.0.0.0:12994->12994/tcp, :::12994->12994/tcp   poller-dc1
ac482332e62c   ghcr.io/netapp/harvest:latest   "bin/poller --poller…"   8 seconds ago   Up 4 seconds   0.0.0.0:12993->12993/tcp, :::12993->12993/tcp   poller-aff250
70be68060d74   ghcr.io/netapp/harvest:latest   "bin/poller --poller…"   8 seconds ago   Up 4 seconds   0.0.0.0:12995->12995/tcp, :::12995->12995/tcp   poller-dc1-zapi
root@scspa2802353001:~/dockertest# 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment