Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update Docker Compose generation process to remove binary dependencies #2046

Merged
merged 2 commits into from
May 9, 2023

Conversation

rahulguptajss
Copy link
Contributor

No description provided.

Hardikl
Hardikl previously approved these changes May 8, 2023
@@ -144,19 +149,21 @@ To upgrade Harvest:
This is needed since the new version may contain new templates, dashboards, or other files not included in the Docker
image.

2. Copy your existing `harvest.yml` into the new Harvest directory created in step #1.
2. [Stop all containers](#stop-all-containers). If you change directories, be sure to shut down any running Harvest containers from the previous directory.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change the Stop all containers section to include more words about this. Something like this:

If you see this error [insert error] when trying to stop your containers, it is probably because you are running docker-compose down from a different directory than up was run. You can still stop and remove the old containers by running: docker ps -qa | xargs docker stop | xargs docker rm Note: This will stop and remove all running containers including any non-Harvest ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

container/onePollerPerContainer/README.md Show resolved Hide resolved
@rahulguptajss rahulguptajss merged commit 456658c into main May 9, 2023
@rahulguptajss rahulguptajss deleted the rg2-docker-without-tar branch May 9, 2023 14:47
@rahulguptajss rahulguptajss linked an issue Aug 3, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change docker compose workflow to not require tar.gz download
3 participants