feat: volume clone info for ZAPI #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulguptajss
commented
Jun 16, 2023
| @@ -73,13 +73,11 @@ endpoints: | |||
| - ^clone.parent_snapshot.name => clone_parent_snapshot | |||
| - ^clone.parent_svm.name => clone_parent_svm | |||
| - ^clone.parent_volume.name => clone_parent_volume | |||
| - ^clone.split_initiated => clone_split_initiated | |||
There was a problem hiding this comment.
removed as it is not available in ZAPI
| @@ -73,13 +73,11 @@ endpoints: | |||
| - ^clone.parent_snapshot.name => clone_parent_snapshot | |||
| - ^clone.parent_svm.name => clone_parent_svm | |||
| - ^clone.parent_volume.name => clone_parent_volume | |||
| - ^clone.split_initiated => clone_split_initiated | |||
| - clone.split_complete_percent => clone_split_complete_percent | |||
There was a problem hiding this comment.
removed as it is not available in Rest
Hardikl
reviewed
Jun 16, 2023
| v.updateAggrMap(disks, aggrDiskMap) | ||
| } | ||
|
|
||
| volumeCloneMap, err := v.getVolumeCloneInfo() |
There was a problem hiding this comment.
Do we want to call this zapi at each poll or as other zapi call happens at plugin frequency to update map but still update volume labels at each poll from cache map ?
There was a problem hiding this comment.
I don't see any reson to cache this call. This Zapi doesn't seem expensive.
cgrinds
reviewed
Jun 16, 2023
Hardikl
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.