feat: Harvest should include numPollers and RSS in autosupport #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/poller/collector/asup.go
Outdated
| // Ignore processes that: | ||
| // - don't pass the allowList, unless the process is using more that 100MB of memory | ||
| // - have no cmdline (these are not interesting) | ||
| if pp.RssBytes < HundredMB && !psAllowListRe.MatchString(name) { |
There was a problem hiding this comment.
Don't we want all harvest pollers even if they take less than 100MB?
There was a problem hiding this comment.
Agreed, even we do process limited process as per allowList, still do we need 100MB criteria ?
There was a problem hiding this comment.
I think, I have misunderstood the condition, it's skipping other processes which are less than 100MB, our all expected processes would any way will be evaluated irrespective of the memory.
Hardikl
approved these changes
Jun 21, 2023
| } else { | ||
| pp.Threads = threads | ||
| } | ||
| msg.Platform.Processes = append(msg.Platform.Processes, pp) |
There was a problem hiding this comment.
Do we need a limit of number of processes stored in slice considering the asup size limit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2065