Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: security hardening guide #2150

Merged
merged 9 commits into from
Jun 30, 2023
Merged

feat: security hardening guide #2150

merged 9 commits into from
Jun 30, 2023

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Jun 22, 2023

Adding security investigation details in private wiki: https://github.com/NetApp/harvest-private/wiki/Security-Checks-Investigation

This first PR is targeted for value difference (bug in our code), next PR will be dashboard related changes.

There is one feedback in afternoon discussion while comparing CI UI with Harvest security dashboard, We mostly have almost all details, we could also able to make similar dashboard.
image

@cla-bot cla-bot bot added the cla-signed label Jun 22, 2023
@Hardikl Hardikl linked an issue Jun 22, 2023 that may be closed by this pull request
@Hardikl Hardikl marked this pull request as draft June 22, 2023 15:24
@Hardikl
Copy link
Contributor Author

Hardikl commented Jun 23, 2023

image

@Hardikl
Copy link
Contributor Author

Hardikl commented Jun 23, 2023

image

@Hardikl Hardikl marked this pull request as ready for review June 23, 2023 13:28
@Hardikl
Copy link
Contributor Author

Hardikl commented Jun 27, 2023

Updated PR with Rahul's changes
image

rahulguptajss
rahulguptajss previously approved these changes Jun 27, 2023
@Hardikl
Copy link
Contributor Author

Hardikl commented Jun 28, 2023

image

Copy link
Contributor

@rahulguptajss rahulguptajss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can possible join Volume SVM tables with labels to show similiar table as we show in other places? Prioritize security columns first.

@Hardikl
Copy link
Contributor Author

Hardikl commented Jun 28, 2023

image

@cgrinds cgrinds merged commit dbb34e7 into main Jun 30, 2023
@cgrinds cgrinds deleted the hl_security_feat branch June 30, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure Harvest covers ONTAP security hardening guide for ONTAP 9
3 participants