-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: security hardening guide #2150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulguptajss
previously approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can possible join Volume SVM tables with labels to show similiar table as we show in other places? Prioritize security columns first.
rahulguptajss
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding security investigation details in private wiki: https://github.com/NetApp/harvest-private/wiki/Security-Checks-Investigation
This first PR is targeted for value difference (bug in our code), next PR will be dashboard related changes.
There is one feedback in afternoon discussion while comparing CI UI with Harvest security dashboard, We mostly have almost all details, we could also able to make similar dashboard.
![image](https://private-user-images.githubusercontent.com/83282894/247976139-fc124dac-6f0e-4277-aab1-99ae9bb57529.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1ODE4MTgsIm5iZiI6MTczOTU4MTUxOCwicGF0aCI6Ii84MzI4Mjg5NC8yNDc5NzYxMzktZmMxMjRkYWMtNmYwZS00Mjc3LWFhYjEtOTlhZTliYjU3NTI5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDAxMDUxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU4YzgzM2M3YjhlZGMzOWQzM2E2NDUzNzA1NmI2OWNlZDA1YTg2NTMzZThkNGM3YjA5NzI1OGIyNGUxZDE2YWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.LYbiV80tj4we1o3D3S-PGGX7dat84TFoPWU9xrHryLM)