feat: when using a credential script, re-auth on 401s #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -179,14 +188,9 @@ func (c *Credentials) GetPollerAuth() (PollerAuth, error) { | |||
| defaultAuth.Username = auth.Username | |||
| } | |||
| c.poller.Username = defaultAuth.Username | |||
| c.poller.Password = defaultAuth.Password | |||
There was a problem hiding this comment.
Why is this line removed?
| @@ -154,7 +164,6 @@ func (c *Credentials) GetPollerAuth() (PollerAuth, error) { | |||
| } | |||
| if auth.Password != "" { | |||
| c.poller.Username = auth.Username | |||
| c.poller.Password = auth.Password | |||
There was a problem hiding this comment.
Why is this line removed?
There was a problem hiding this comment.
It the value is written back to a poller's password, it's indistinguishable from the harvest.yml containing a poller with that password, which will break the precedent rules
There was a problem hiding this comment.
The code flow appears to be confusing because the method in question returns a value called defaultAuth, which includes the username. However, within the same method, the username is also being set in the poller. Therefore, it seems that the username is being consumed in two different ways.
rahulguptajss
approved these changes
Jul 14, 2023
Hardikl
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2168