Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handled when metric not found in plugin #2281

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Aug 11, 2023

% ./bin/poller -p aff-250 --promPort 18001 -c Rest -o Aggregate
2023-08-11T16:53:56+05:30 INF poller/poller.go:194 > Init Poller=aff-250 configPath=./harvest.yml logLevel=info version="harvest version 23.08.1116-v23.05.0 (commit 0ff1e6d6) (build date 2023-08-11T16:53:50+0530) darwin/amd64\n"
2023-08-11T16:53:56+05:30 INF poller/poller.go:231 > started in foreground Poller=aff-250 pid=64704
2023-08-11T16:53:58+05:30 INF collector/helpers.go:139 > best-fit template Poller=aff-250 collector=Rest:Aggregate path=conf/rest/9.10.0/aggr.yaml v=9.11.0
2023-08-11T16:53:58+05:30 INF poller/poller.go:349 > Autosupport scheduled. Poller=aff-250 asupSchedule=24h
2023-08-11T16:53:58+05:30 INF poller/poller.go:358 > poller start-up complete Poller=aff-250
2023-08-11T16:53:58+05:30 INF prometheus/httpd.go:40 > server listen Poller=aff-250 exporter=prometheus1 url=http://:18001/metrics
2023-08-11T16:53:58+05:30 INF poller/poller.go:506 > updated status, up collectors: 1 (of 1), up exporters: 1 (of 1) Poller=aff-250
2023-08-11T16:54:01+05:30 WRN metricagent/metric_agent.go:136 > Poller=aff-250 computeMetrics: errors for metric not found=["strconv.Atoi: parsing \"block_storage.hybrid_cache.disk_count\": invalid syntax","strconv.Atoi: parsing \"block_storage.hybrid_cache.disk_count\": invalid syntax","strconv.Atoi: parsing \"block_storage.hybrid_cache.disk_count\": invalid syntax"] object=Aggregate plugin=Rest:MetricAgent
2023-08-11T16:54:01+05:30 INF collector/collector.go:483 > Collected Poller=aff-250 apiMs=3168 calcMs=0 collector=Rest:Aggregate instances=3 metrics=115 parseMs=1 pluginMs=0

With these changes,
All metrics from compute_metric plugins from template are generated as expected.

@rahulguptajss rahulguptajss merged commit 5162835 into main Aug 14, 2023
@rahulguptajss rahulguptajss deleted the hl_aggr_fix branch August 14, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants