feat: adding rw_ctx zapiperf object template #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Added 
|
cgrinds
reviewed
Nov 17, 2023
| @@ -4704,6 +4704,576 @@ | |||
| ], | |||
| "title": "iSCSI Frontend", | |||
| "type": "row" | |||
| }, | |||
| { | |||
| "collapsed": true, | |||
There was a problem hiding this comment.
PAS has values 0-1 in its graph. Do we need same here?
There was a problem hiding this comment.
We haven't specify the any min/max range, so it will show graph based on the values.
There was a problem hiding this comment.
I see some of these panels have max defined while others don't
Also CIFS giveups has filled region active and others don't
|
|
|
We also need a burt to add the RestPerf side |
rahulguptajss
approved these changes
Nov 22, 2023
Created the burt for RestPerf side changes: https://burtweb-prd.eng.netapp.com/burt/burt-bin/start?burt-id=1599431 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks required for this feature.