Skip to content

Commit

Permalink
Include protocol in readme examples setting endpoint from wsdl_domain (
Browse files Browse the repository at this point in the history
…#477)

The `wsdl_domain` is just a domain/hostname, no protocol, however
`endpoint` expects to include a protocol, so when you're buliding the
`endpoint` from the `wsdl_domain`, you need to prefix it with a
protocol.
  • Loading branch information
cgunther authored May 25, 2021
1 parent e087d29 commit 33594f4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ NetSuite.configure do
# the endpoint indicated in the > 2018_2 wsdl is invalid
# you must set the endpoint directly
# https://github.com/NetSweet/netsuite/pull/473
endpoint "#{wsdl_domain}/services/NetSuitePort_#{api_version}"
endpoint "https://#{wsdl_domain}/services/NetSuitePort_#{api_version}"
end
```

Expand Down Expand Up @@ -173,7 +173,7 @@ NetSuite.configure do
# the endpoint indicated in the > 2018_2 wsdl is invalid
# you must set the endpoint directly
# https://github.com/NetSweet/netsuite/pull/473
endpoint "#{wsdl_domain}/services/NetSuitePort_#{api_version}"
endpoint "https://#{wsdl_domain}/services/NetSuitePort_#{api_version}"
end
```

Expand Down

0 comments on commit 33594f4

Please sign in to comment.