Properly extract external_id from advanced search results #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you performed an advanced search specifying which columns to return
and included externalId, you wouldn't be able to get the external_id
from the resulting record via the usual external_id method. This now
matches how internal_id is extracted.
Prior to this, calls to external_id returned:
```
> record.external_id
=> {:@external_id=>"customer_1"}
```
Now, it returns:
```
> record.external_id
=> "customer_1"
```
|
Awesome fix! Thanks. |
diegopolido
pushed a commit
to penrosehill/netsuite
that referenced
this pull request
Oct 7, 2021
If you performed an advanced search specifying which columns to return
and included externalId, you wouldn't be able to get the external_id
from the resulting record via the usual external_id method. This now
matches how internal_id is extracted.
Prior to this, calls to external_id returned:
```
> record.external_id
=> {:@external_id=>"customer_1"}
```
Now, it returns:
```
> record.external_id
=> "customer_1"
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you performed an advanced search specifying which columns to return and included externalId, you wouldn't be able to get the external_id from the resulting record via the usual external_id method. This now matches how internal_id is extracted.
Prior to this, calls to external_id returned:
Now, it returns:
This originally surfaced in #470 as part of a larger change, but we're exploring taking that in a different direction, so extracted this out to it's own PR.