Move definition of search_joins
attribute from records to search action
#511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was up to each record to define this attribute, if it
offered the search action. This created scenarios where a record like
Bin
offered the
search
action, but didn't define thesearch_joins
attribute and therefore searching bins would error:
due to
SearchResult
assuming the record had such an attribute:netsuite/lib/netsuite/support/search_result.rb
Line 112 in 9f10005
Now adding the
search
action to a record automatically adds thenecessary
search_joins
attribute.The attribute was previously defined on
AssemblyComponent
,SerializedInventoryItemLocation
, andWorkOrderItem
, however none ofthose support actions at all, let alone the
search
action. They're allrecords for sublist items. I suspect the attribute was erroneously
introduced in the first place as a result of copy/pasting to create the
record.