Add support for NullFieldList (starting with credit memos and invoices) #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullFieldList is used to either clear an existing value on update, or avoid a default being applied on adding a record. My use case only required support for credit memos and invoices, so I started there, but this could likely be added to most records. This was heavily inspired by @gmike11's work in NetSweet#481, but that seems to lump a bunch of changes together. This also solves NetSweet#398. Where NetSweet#481 manipulated the XML request body to address that the `<platformCore:nullFieldList>` needs to always use the `platformCore` namespace, as opposed to the record's normal namespace (ie `transSale` for invoice) as happens for any other field, I tried to address that on the `#to_record` side.
cgunther
force-pushed
the
null-field-list
branch
from
19d5c24 to
2a416eb
Compare
|
Awesome change, as always! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NullFieldList is used to either clear an existing value on update, or
avoid a default being applied on adding a record.
My use case only required support for credit memos and invoices, so I
started there, but this could likely be added to most records.
This was heavily inspired by @gmike11's work in #481, but that seems to
lump a bunch of changes together. This also solves #398.
Where #481 manipulated the XML request body to address that the
<platformCore:nullFieldList>needs to always use theplatformCorenamespace, as opposed to the record's normal namespace (ie
transSalefor invoice) as happens for any other field, I tried to address that on
the
#to_recordside.