Optionally pass in proxy parameter to Savon
#548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Savon will call `to_s` on any `proxy` value passed in so it will treat `nil` like an empty string instead of not using it. This causes requests to fail with an invalid proxy. This change will not pass in a value for `proxy` if the attribute is `nil`. This change also updates history with addition of the proxy attribute.
iloveitaly
requested changes
Jun 14, 2022
|
@dbecker-stripe what version of savon fixed the weird issue you were running into? I think it's worth adding that as a gemspec dependency. |
andrewdicken-stripe
added a commit
to andrewdicken-stripe/netsuite
that referenced
this pull request
Apr 19, 2023
This reverts commit 7490788.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Savon will call
to_son anyproxyvalue passed in so it will treatnillike an empty string instead of not using it. This causes requests to fail with an invalid proxy. This change will not pass in a value forproxyif the attribute isnil.This change also updates history with addition of the proxy attribute.
A fix was added to version 2.12.0 of savon but this changes allows netsuite to be compatible with earlier versions of savon.