Ignore status detail of after_submit_failed in error handling #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issue #444, where some successful requests return an empty error object. See https://system.netsuite.com/help/helpcenter/en_US/WSDiff/2018_2/FolderComparisonReport_files/FileComparisonReport24.html, line 914 for the change to the platformCore schema, https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_4407992281.html for a description of afterSubmit scripts, and https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_N3536574.html#bridgehead_1515748728 for a discussion of error reporting for these scripts. Also added a line for File requests in the add action spec b/c the existing fixture already includes the `after_submit_failed` field. Co-authored-by: Lily Burtness <lily.burtness@charitywater.org> Co-authored-by: Shana Schundler <shana.schundler@charitywater.org>
flats
changed the title
flats
changed the title
|
@flats This is a great change! I'll merge this in, would you mind submitting another PR with a changelog entry? |
|
@iloveitaly great! No problem at all: #551. Figured it's more of an addition than a fix b/c it's really adding support for more recent API versions. |
iloveitaly
pushed a commit
that referenced
this pull request
Jun 17, 2022
Per maintainer's request, #550 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #444, where some successful requests return an empty error object.
See https://system.netsuite.com/help/helpcenter/en_US/WSDiff/2018_2/FolderComparisonReport_files/FileComparisonReport24.html, line 914 for the change to the platformCore schema, https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_4407992281.html for a description of afterSubmit scripts, and https://docs.oracle.com/en/cloud/saas/netsuite/ns-online-help/section_N3536574.html#bridgehead_1515748728 for a discussion of error reporting for these scripts.
Also adds a line for File requests in the add action spec b/c the existing fixture already includes the
after_submit_failedfield.Co-authored-by: Lily Burtness lily.burtness@charitywater.org
Co-authored-by: Shana Schundler shana.schundler@charitywater.org