Set resource max limit to 10240 on macOS #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NJRoadfan Would you be able to test this on your Catalina Mac? The Macs I have at hand are all running too new versions... |
|
This appears to work fine on Catalina. The main afpd daemon is throwing the set limits error too according to the log, but without any ill effects. Maybe the 10240 limit should be applied there as well? |
rdmark
force-pushed
the
1793-macos-cnid_metad-failing-to-load-setlimits-invalid-argument
branch
from
3bec172 to
c426329
Compare
rdmark
force-pushed
the
1793-macos-cnid_metad-failing-to-load-setlimits-invalid-argument
branch
from
c426329 to
10aba37
Compare
|
Good idea. Let's apply this workaround for afpd too. Please test the updated PR when you have the opportunity! |
|
rdmark
deleted the
1793-macos-cnid_metad-failing-to-load-setlimits-invalid-argument
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions of macOS such as 10.15 Catalina will throw an error when ulimit is set to too high a number. This PR uses a compliant value when calling
setrlimit()on macOS specifically.