Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic authentication #335

Closed
ManicRooks opened this issue Nov 4, 2014 · 4 comments
Closed

Basic authentication #335

ManicRooks opened this issue Nov 4, 2014 · 4 comments

Comments

@ManicRooks
Copy link

I have hystrix stream setup on a public web application. It is protected by a basic authentication filter for improved security. It would be nice to have the dashboard support basic authentication.

ManicRooks pushed a commit to ManicRooks/Hystrix that referenced this issue Nov 4, 2014
@benjchristensen
Copy link
Contributor

App servers often have many internal resources that are not exposed publicly and are protected via mechanisms such as servlet filters (earlier in the filter chain) or web.xml rules.

Is there a particular issue causing a need to modify the Hystrix servlet itself as opposed to protecting it via one of the various other approaches such as servlet filters or web.xml security rules?

@ManicRooks
Copy link
Author

I didn't modify the hystrix servlet, I used an external servlet filter for security. In this pull request, the hystrix dashboard was modified to support the custom authorization http header.

@benjchristensen
Copy link
Contributor

The pull request is in #336

@benjchristensen benjchristensen added this to the 1.4.x milestone Dec 12, 2014
@mattrjacobs
Copy link
Contributor

Closed via #369, #336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants