Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make inner classes static where possible, and remove outer class refe… #1231

Merged
merged 1 commit into from
Jun 3, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ public Long call() {
}
}

private class MetricsPollerThreadFactory implements ThreadFactory {
private static class MetricsPollerThreadFactory implements ThreadFactory {
private static final String MetricsThreadName = "HystrixMetricPoller";

private final ThreadFactory defaultFactory = Executors.defaultThreadFactory();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ LongMaxUpdater getMaxUpdater(HystrixRollingNumberEvent type) {
* <p>
* benjchristensen => This implementation was chosen based on performance testing I did and documented at: http://benjchristensen.com/2011/10/08/atomiccirculararray/
*/
/* package */class BucketCircularArray implements Iterable<Bucket> {
/* package */static class BucketCircularArray implements Iterable<Bucket> {
private final AtomicReference<ListState> state;
private final int dataLength; // we don't resize, we always stay the same, so remember this
private final int numBuckets;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ private int computePercentile(double percent) {
* <p>
* benjchristensen => This implementation was chosen based on performance testing I did and documented at: http://benjchristensen.com/2011/10/08/atomiccirculararray/
*/
/* package for testing */ class BucketCircularArray implements Iterable<Bucket> {
/* package for testing */ static class BucketCircularArray implements Iterable<Bucket> {
private final AtomicReference<ListState> state;
private final int dataLength; // we don't resize, we always stay the same, so remember this
private final int numBuckets;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public void run() {
return new TimerReference(listener, f);
}

private class TimerReference extends SoftReference<TimerListener> {
private static class TimerReference extends SoftReference<TimerListener> {

private final ScheduledFuture<?> f;

Expand Down