Add threadPool maximumSize configuration #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 3, 2016 11:38
bltb
reviewed
Oct 7, 2016
| threadPool.setCorePoolSize(dynamicCoreSize); | ||
| threadPool.setMaximumPoolSize(dynamicCoreSize); // we always want maxSize the same as coreSize, we are not using a dynamically resizing pool | ||
| threadPool.setMaximumPoolSize(dynamicMaximumSize); | ||
| } | ||
|
|
||
| threadPool.setKeepAliveTime(properties.keepAliveTimeMinutes().get(), TimeUnit.MINUTES); // this doesn't really matter since we're not resizing |
There was a problem hiding this comment.
@mattrjacobs , you might like to remove this comment about "this doesn't really matter" ... 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it is possible to set
coreSize < maximumSizeand have a thread pool which can give up threads if they become inactive (subject to the keep-alive time).Design considerations:
IllegalArgumentExceptionis thrown if aThreadPoolExecutoris configured withcoreSize > maximumSize. When that condition occurs when the constructor is invoked, this PR chooses to usecoreSizeformaximumSizeto avoid the error and logs something to the user.coreSizeas the default value formaximumSize. This should allow a clean migration, as no one currently hasmaximumValueconfigured. So without that config, Hystrix should configure itself as before - a fixed size threadpool of sizecoreSize. Further configuration can then set these independently.This addresses #1242