Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect thread pool rate calculations in dashboard #139

Merged
merged 1 commit into from
Jun 7, 2013

Conversation

fkjellberg
Copy link
Contributor

Fixed incorrect thread pool rate calculations that did not take into account the rolling counter window size, thus giving a ten times too large value.

Also removed two data elements, propertyValue_corePoolSize and rollingThreadExecutions. They are not created in hystrix-metrics-event-stream and are not used as far as I can see.

…account the rolling counter window size, thus giving a ten times too large value
@cloudbees-pull-request-builder

Hystrix-pull-requests #14 FAILURE
Looks like there's a problem with this pull request

opuneet added a commit that referenced this pull request Jun 7, 2013
Fixed incorrect thread pool rate calculations in dashboard
@opuneet opuneet merged commit 38130a9 into Netflix:master Jun 7, 2013
@opuneet
Copy link
Contributor

opuneet commented Jun 7, 2013

This looks great. Just validated this and I'm pushing this fix to our own internal dashboard. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants