Add option to raise HystrixRuntimeException #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @michaelcowan ! It looks like you've used some Java8 classes in this PR. Can you refactor to target JDK6? We're still targeting that JDK until we get to Hystrix 2. |
|
@mattrjacobs I've looked through the PR and can't see any Java 8 classes 😕 I was careful to only repeat existing patterns and used JDK1.6 when building locally. |
|
Apologies - I must have done something incorrectly when I ran this locally. Build passes for me, and visual inspection looks good too. Thanks for the contribution! |
|
So I'm just now discovering this and thought I would add my 2 cents. While this is a step in the right direction it does not completely solve the issue. Think about a developer who is using the MVC pattern - the service facade layer of the application is where all of this hystrix "stuff" comes into play. The API of that layer is the contract between this layer & the layer above it (for a web application - some controller/restful API layer). This addition makes the caller of the service facade layer have to know specific details that Hystrix is involved by having to catch HystrixRuntimeException, look for a fallback exception (which is generally a FallbackInvocationException) and then have to read the cause from that. Why can't we simply throw whatever exception is thrown from the fallback? I have a post on StackOverflow which describes the scenario I'm trying to handle. http://stackoverflow.com/questions/40495259/capture-exception-thrown-by-hystrix-fallback |
|
Actually I was able to solve my use case using this approach. I posted my solution back on my stackoverflow post: http://stackoverflow.com/questions/40495259/capture-exception-thrown-by-hystrix-fallback/40529532#40529532 |
|
Actually it seems that this only works while the circuit is closed. Once the circuit is tripped open the HystrixRuntimeException gets propagated back up. |
|
@edeandrea answered here: http://stackoverflow.com/a/40551009/1325109 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to allow HystrixRuntimeException to be thrown by
HystrixCommandAspect.The new property raiseHystrixExceptions is supported by both
DefaultPropertiesandHystrixCommand.e.g.
This pattern is extensible should people wish to add support for other Hystrix exceptions.
PR requested by @dmgcodevil