Expose current HystrixCommand to fns #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ohpauleez noticed that the current HystrixCommand was inaccessible from :fallback-fn. This change introduces a dynamic var, *command* that exposes the currently running HystrixCommand instance so it can be interrogated as needed. At some point, if the dynamic var doesn't work out or proves error-prone or unwieldy, we may introduce alternative functions that explicitly pass the function as the first arg.
|
Hystrix-pull-requests #32 FAILURE |
benjchristensen
added a commit
that referenced
this pull request
Jul 26, 2013
Expose current HystrixCommand to fns
|
Are you guys able to squeeze this into a release soon? I'd like to switch out my hystrix shim back to the original hystrix-clj for my production code. |
|
I plan on releasing Hystrix 1.3 later this week which includes this change. -- On August 1, 2013 at 6:43:29 AM, Paul deGrandis (notifications@github.com) wrote: Are you guys able to squeeze this into a release soon? I'd like to switch out my hystrix shim back to the original hystrix-clj for my production code. — |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ohpauleez noticed that the current HystrixCommand was inaccessible from
:fallback-fn. This change introduces a dynamic var, command that
exposes the currently running HystrixCommand instance so it can be
interrogated as needed. At some point, if the dynamic var doesn't work
out or proves error-prone or unwieldy, we may introduce alternative
functions that explicitly pass the function as the first arg.