Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rx support to hystrix-clj. #170

Merged
merged 1 commit into from
Aug 12, 2013

Conversation

daveray
Copy link
Contributor

@daveray daveray commented Aug 4, 2013

Add observe, observe-later, and observer-later-on functions to
hystrix-clj corresponding to observe(), toObservable() and
toObservable(Scheduler) methods added to Hystrix respectively.

I'm wondering whether the toObservable methods really need to be wrapped, or if they're sufficiently fringe that they should be left out to keep the wrapper light. Thoughts?

Add observe, observe-later, and observer-later-on functions to
hystrix-clj corresponding to observe(), toObservable() and
toObservable(Scheduler) methods added to Hystrix respectively.
@cloudbees-pull-request-builder

Hystrix-pull-requests #42 ABORTED

@josephwilk
Copy link
Contributor

Ah, I was just thinking about this, missed the PR. I'll cancel mine.

I realise now that what I really wanted was observe-later not observe. Look forward to this being merged.

@daveray
Copy link
Contributor Author

daveray commented Aug 12, 2013

@josephwilk Cool. What do you thinkg of the name observe-later? We were just discussing this last week trying to guess under what conditions someone would choose to use that form and whether the name made sense.

@josephwilk
Copy link
Contributor

I like observe-later, its intent and difference from observe was very clear to me.

Also works nicely with observe-later-on

@daveray
Copy link
Contributor Author

daveray commented Aug 12, 2013

Thanks!

benjchristensen added a commit that referenced this pull request Aug 12, 2013
@benjchristensen benjchristensen merged commit 8118301 into Netflix:master Aug 12, 2013
@daveray daveray deleted the hystrix-clj-observe branch August 12, 2013 19:20
@benjchristensen
Copy link
Contributor

Merged and released in 1.3.1

@daveray
Copy link
Contributor Author

daveray commented Aug 12, 2013

Thanks Ben! Hopefully it works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants