Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Got Javanica unit tests compiling (but failing) #359

Merged
merged 3 commits into from
Dec 15, 2014

Conversation

mattrjacobs
Copy link
Contributor

I still see errors of the form :
java.lang.NoSuchMethodError: java.util.concurrent.ConcurrentHashMap.keySet()Ljava/util/concurrent/ConcurrentHashMap$KeySetView.

This looks related to a Java7/Java8 mismatch described here: https://gist.github.com/AlainODea/1375759b8720a3f9f094

cc @sawano in case you've seen this before

@cloudbees-pull-request-builder

Hystrix-pull-requests #182 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder

Hystrix-pull-requests #185 FAILURE
Looks like there's a problem with this pull request

mattrjacobs added a commit that referenced this pull request Dec 15, 2014
Got Javanica unit tests compiling (but failing).  While the bootclasspath issue is being sorted out, temporarily comment out hystrix-javanica to allow master to move forward
@mattrjacobs mattrjacobs merged commit f2765eb into Netflix:master Dec 15, 2014
@mattrjacobs mattrjacobs deleted the fix-javanica-unit-tests branch December 15, 2014 20:26
@sawano
Copy link
Contributor

sawano commented Dec 15, 2014

No, haven't seen that one.
I tried your branch and am able to run the tests in hystrix-javanica using both jdk 6 and 8 (./gradlew clean test -p hystrix-contrib/hystrix-javanica)
I'm not that good with gradle, am I missing something in the execution of tests?

@dmgcodevil
Copy link
Contributor

I didn't have a chance to check it, will look into it soon

On Mon, Dec 15, 2014 at 11:26 PM, Daniel Sawano notifications@github.com
wrote:

No, haven't seen that one.
I tried your branch and am able to run the tests in hystrix-javanica using
both jdk 6 and 8 (./gradlew clean test -p hystrix-contrib/hystrix-javanica
)
I'm not that good with gradle, am I missing something in the execution of
tests?


Reply to this email directly or view it on GitHub
#359 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants