Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching hook orders from 1.3.x #511

Merged
merged 4 commits into from
Jan 14, 2015
Merged

Matching hook orders from 1.3.x #511

merged 4 commits into from
Jan 14, 2015

Conversation

mattrjacobs
Copy link
Contributor

Uncovered Issue #510 during this investigation. Will update this PR once that is resolved.

@cloudbees-pull-request-builder
Copy link

Hystrix-pull-requests #223 FAILURE
Looks like there's a problem with this pull request

Now calling thread only handles thread-end in non-timeout case.
6aedbfb 
This allows Hystrix-provided thread to handle it in timeout case after calling thread has walked away
@mattrjacobs mattrjacobs changed the title Matching hook orders from 1.3.x and fixing short-circuited fallback missing an 'onCompleted' Matching hook orders from 1.3.x Jan 14, 2015
@mattrjacobs
Copy link
Contributor Author

2 bugs uncovered by copying over hook execution orders from 1.3.x branch:

  • Short-circuiting with fallback was not triggering onComplete
  • Timeout (with or without fallback) was not triggering onRunSuccess when the Hystrix thread ran successfully but exceeded the command timeout

@cloudbees-pull-request-builder
Copy link

Hystrix-pull-requests #224 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder
Copy link

Hystrix-pull-requests #225 SUCCESS
This pull request looks good

mattrjacobs added a commit that referenced this pull request Jan 14, 2015
@mattrjacobs
Merge pull request #511 from mattrjacobs/missing-short-circuit-on-com…
ef4794d 
…plete-hook

Matching hook orders from 1.3.x
@mattrjacobs mattrjacobs merged commit ef4794d into Netflix:master Jan 14, 2015
@mattrjacobs mattrjacobs deleted the missing-short-circuit-on-complete-hook branch January 14, 2015 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattrjacobs @cloudbees-pull-request-builder