Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a synthetic exception in the semaphore execution and short-circuited case #527

Conversation

mattrjacobs
Copy link
Contributor

This allows onError() hook to always receive a non-null Exception.

Fixes #513 for master

…ircuited case

that gets passed to onError() hook
@cloudbees-pull-request-builder

Hystrix-pull-requests #231 SUCCESS
This pull request looks good

mattrjacobs added a commit that referenced this pull request Jan 19, 2015
…n-error-hook

Creating a synthetic exception in the semaphore execution and short-circuited case
@mattrjacobs mattrjacobs merged commit f0c4c90 into Netflix:master Jan 19, 2015
@mattrjacobs mattrjacobs deleted the always-pass-non-null-ex-to-on-error-hook branch January 19, 2015 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onError hook sometimes invoked with null exception
2 participants