Making provided scope transtive #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjchristensen
added a commit
that referenced
this pull request
Jan 2, 2013
Making provided scope transtive
|
Thanks Justin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally junit:junit:4.10 actually points to junit:junit-dep:4.10. And that single hop is where things were breaking. This commit will fix all transitive issues related to the provided scope.
I'd actually recommend changing all junit:junit references to junit:junit-dep. The problem with junit:junit is that it bundles hamcrest in it, so you're limited in your ability to include a better hamcrest matching libraries since junit pollutes the classpath.