Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution hooks #71

Merged
merged 8 commits into from
Jan 7, 2013
Merged

Execution hooks #71

merged 8 commits into from
Jan 7, 2013

Conversation

benjchristensen
Copy link
Contributor

Execution Hooks via Plugin #10

A few other cleanup commits along for the ride that I did as I worked on the execution hooks.

This makes the Javadocs comply with changes done in bfb6696
Plugins can not be modified after registration so caching is okay.
Generally not good practice to be catching Throwable so changing to Exception.
Execution Hooks via Plugin #10
I think onComplete is clearer since the response can be either from run() or getFallback()
benjchristensen added a commit that referenced this pull request Jan 7, 2013
@benjchristensen benjchristensen merged commit e723beb into Netflix:master Jan 7, 2013
@benjchristensen benjchristensen deleted the execution-hooks branch January 7, 2013 19:18
@mcacker
Copy link

mcacker commented Jan 8, 2013

Works great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants