Add validation for rollingCountBadRequests #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix adds validation for rollingCountBadRequests (added to the dashboard circuit template in v1.4.7), and also sets it to a default of 0 to provide backwards compatibility with older streams.
|
NetflixOSS » Hystrix » Hystrix-pull-requests #142 SUCCESS |
|
Thanks for the PR. Sorry for the delay merging - I was out of the country on vacation. In addition, I opened #836 to see if there's a more general approach to allowing dashboards to be more resilient against older metric streams |
mattrjacobs
added a commit
that referenced
this pull request
Jul 22, 2015
Add validation for rollingCountBadRequests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix adds validation for rollingCountBadRequests (added to the dashboard circuit template in v1.4.7), and also sets it to a default of 0 to provide backwards compatibility with older streams.