Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple responses per collapser arg #890

Merged

Conversation

mattrjacobs
Copy link
Contributor

Replaces #881. Fixed memory consumption issue by replacing ReplaySubject with PublishSubject and adding an AtomicBoolean to CollapsedRequestObservableFunction to track if a value has been set on the response yet

@cloudbees-pull-request-builder

NetflixOSS » Hystrix » Hystrix-pull-requests #175 SUCCESS
This pull request looks good

@mattrjacobs
Copy link
Contributor Author

This did not degrade performance according to new JMH benchmarks (#882), and also worked as expected in Netflix canary.

mattrjacobs added a commit that referenced this pull request Sep 10, 2015
…pser-arg

Multiple responses per collapser arg
@mattrjacobs mattrjacobs merged commit 0e18402 into Netflix:1.4.x Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants