[hystrix-dashboard] isCircuitBreakerOpen is assumed to be a boolean #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the HystrixStream servlet, however these replace() operations assume that it is a string. There are certain instances where Turbine does not return back a String when isCircuitBreakerOpen is aggregated. This enforces the boolean to be a string first, regardless of what Turbine may/may not do.
|
NetflixOSS » Hystrix » Hystrix-pull-requests #201 SUCCESS |
|
Thanks @chrisgray |
mattrjacobs
added a commit
that referenced
this pull request
Oct 14, 2015
…reakeropen [hystrix-dashboard] isCircuitBreakerOpen is assumed to be a boolean
spencergibb
added a commit
to spring-cloud/spring-cloud-netflix
that referenced
this pull request
Oct 15, 2015
spencergibb
added a commit
to spring-cloud/spring-cloud-netflix
that referenced
this pull request
Oct 19, 2015
spencergibb
added a commit
to spring-cloud/spring-cloud-netflix
that referenced
this pull request
Dec 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isCircuitBreakeropen is assumed to be a boolean from the HystrixStream servlet, however these replace() operations assume that it is a string. There are certain instances where Turbine does not return back a String when isCircuitBreakerOpen is aggregated. This enforces the boolean to be a string first, regardless of what Turbine may/may not do.