Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sudo usage to start C* as a configurable entry #584

Merged
merged 5 commits into from
Sep 29, 2017

Conversation

vinaykumarchella
Copy link
Contributor

No description provided.

Copy link
Contributor

@arunagrawal84 arunagrawal84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -76,6 +76,11 @@ class TestFlushTask extends Specification {
public String getFlushInterval() {
return flushInterval;
}
@Override
boolean useSudo()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this required here? It already extends FakeConfiguration.java.

# Conflicts:
#	priam/src/main/java/com/netflix/priam/defaultimpl/CassandraProcessManager.java
#	priam/src/main/java/com/netflix/priam/defaultimpl/PriamConfiguration.java
#	priam/src/test/java/com/netflix/priam/FakeConfiguration.java
#	priam/src/test/java/com/netflix/priam/FakeConfigurationMurmur3.java
@vinaykumarchella vinaykumarchella merged commit 57b91ea into Netflix:3.x Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants