Use put api from s3 instead of multi-part for small objects. #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolynch
approved these changes
Nov 2, 2017
| SnappyOutputStream compress = new SnappyOutputStream(byteArrayOutputStream)) { | ||
| byte data[] = new byte[BUFFER]; | ||
| int count; | ||
| while ((count = inputStream.read(data, 0, data.length)) != -1) { |
There was a problem hiding this comment.
nit: can just do read(data)
| @@ -35,6 +36,22 @@ | |||
| } | |||
|
|
|||
| @Override | |||
| public byte[] compress(InputStream inputStream) throws IOException { | |||
| try (ByteArrayOutputStream byteArrayOutputStream = new ByteArrayOutputStream(); | |||
| SnappyOutputStream compress = new SnappyOutputStream(byteArrayOutputStream)) { | |||
| @@ -35,6 +36,22 @@ | |||
| } | |||
|
|
|||
| @Override | |||
| public byte[] compress(InputStream inputStream) throws IOException { | |||
There was a problem hiding this comment.
Any reason not to just retrieve the ChunkedStream from earlier compress and call next() until it's done?
|
|
||
| if (logger.isDebugEnabled()) | ||
| logger.debug("Successfully uploaded file with putObject: {} and etag: {}", path.getRemotePath(), upload.getETag()); | ||
| }catch (Exception e) { |
| } finally { | ||
| IOUtils.closeQuietly(in); | ||
| } | ||
| }else |
jolynch
approved these changes
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.