This repository has been archived by the owner on Mar 4, 2021. It is now read-only.
The original condition should be returned in addition to the new one sin... #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfasin
added a commit
that referenced
this pull request
Aug 29, 2014
The original condition should be returned in addition to the new one sin...
…since unit-test will otherwise fail: the reason for that is that the unit-test checks two things: 1. selected instances 2. terminated and no instance should be selected if we reached the max. Though the previous fix ensures that we won’t kill the chosen instance - according to the unit-test we should not even choose it (strict approach).
|
SimianArmy-pull-requests #144 SUCCESS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ce unit-test will otherwise fail:
the reason for that is that the unit-test checks two things:
and no instance should be selected if we reached the max.
Though the previous fix ensures that we won’t kill the chosen instance - according to the unit-test we should not even choose it (strict approach).