This repository has been archived by the owner on Mar 4, 2021. It is now read-only.
Add cross-zone load balancing conformity rule #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 30, 2014 15:53
* master: The original condition should be returned in addition to the new one since unit-test will otherwise fail: the reason for that is that the unit-test checks two things: 1. selected instances 2. terminated maxTerminationsPerDay was checked only once for the group before the iteration over the instances while ee should check if maxTerminationsPerDay was exceeded before trying to terminate *any* instance.
|
SimianArmy-pull-requests #145 SUCCESS |
coryb
added a commit
that referenced
this pull request
Sep 30, 2014
Add cross-zone load balancing conformity rule
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From our experience, cross-zone load balancing should be enabled for pretty much all ELBs. This conformity rule checks that this attribute is set for all load balancers associated with a given cluster. You can enable this rule by setting simianarmy.conformity.rule.CrossZoneLoadBalancing.enabled to true in your configuration.