Skip to content
This repository has been archived by the owner on Mar 4, 2021. It is now read-only.

replace hardcoded "owner" with property #212

Merged
merged 1 commit into from
Oct 13, 2015

Conversation

pbuckley
Copy link
Contributor

use BasicSimianArmyContext.GLOBAL_OWNER_TAGKEY instead of hardcoded
owner

I was getting this error trying to run JanitorMonkey with Edda:

2015-10-09 14:58:00.991 -java.lang.RuntimeException: Failed to
get valid document from
http://localhost:8080/view/instances;_since=1436626680922;state.name=running;tags.key=owner;_expand:(instanceId,tags:(key,value)),
got: null

Even with janitor.properties containing:
simianarmy.janitor.edda.endpoint.us-east-1 = http://localhost:8080/api/v2

And with simianarmy.properties containing:
simianarmy.tags.owner = NotOwner

use BasicSimianArmyContext.GLOBAL_OWNER_TAGKEY instead of hardcoded
owner

I was getting this error trying to run JanitorMonkey with Edda:

2015-10-09 14:58:00.991 -java.lang.RuntimeException: Failed to
get valid document from
http://localhost:8080/view/instances;_since=1436626680922;state.name=running;tags.key=owner;_expand:(instanceId,tags:(key,value)),
got: null

Even with janitor.properties containing:
simianarmy.janitor.edda.endpoint.us-east-1 = http://localhost:8080/api/v2

And with simianarmy.properties containing:
simianarmy.tags.owner = NotOwner
@cloudbees-pull-request-builder

SimianArmy-pull-requests #199 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder

NetflixOSS » SimianArmy » SimianArmy-pull-requests #27 SUCCESS
This pull request looks good

ebukoski added a commit that referenced this pull request Oct 13, 2015
replace hardcoded "owner" with property
@ebukoski ebukoski merged commit 09cb41e into Netflix:master Oct 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants