This repository has been archived by the owner on Mar 4, 2021. It is now read-only.
Redo: Adding feature to specify resource types for untaggedResource Rule #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM thanks for adding the tests! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ebukoski My last PR was old and so far behind master that I just reset and created this PR based on an up-to-date clone. This PR has a couple of tests included.
Sometimes you don't care if specific resource types have tags (like Launch Configurations), but you want to require tags on other resource types (like Instances), yet you still want Janitor Monkey to track and clean-up all resources.
For example, EBS Volumes are attached after our deployment automation is finished and they therefore don't get a proper owner tag (even though Volume Tagging Monkey transfers the attached Instance owner tag to the meta-data EBS Volume tag). Additionally, Launch Configurations don't even support tags, so enabling the untaggedResourceRule seems to flag all Launch Configurations.
This feature allows one to opt-in only the resources they care about really having tags for the untaggedResourceRule. If the resource type is not opted-in for Janitor Monkey at all that resource type will be ignored even if included in the untagged resource configuration.