This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
feature: Not storing duplicate data in external storage #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Misencik <simon.misencik@gmail.com>
|
Build failed because of dependency on this PR: Netflix/conductor#3383 |
|
This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 7 days. |
|
Netflix/conductor#3383 was merged. Please rerun the build. |
|
Hey @apanicker-nflx , could we get a retrigger here ? and then a review. Thank you, |
SimonMisencik
force-pushed
the
remove_duplication_from_external_storage
branch
from
d5f96d6 to
b3301ae
Compare
Signed-off-by: Simon Misencik <simon.misencik@gmail.com>
JumasJM
pushed a commit
to FRINXio/conductor-community
that referenced
this pull request
Oct 23, 2023
* Not storing duplicate data in external storage Signed-off-by: Simon Misencik <simon.misencik@gmail.com> * Add dependencies Signed-off-by: Simon Misencik <simon.misencik@gmail.com> --------- Signed-off-by: Simon Misencik <simon.misencik@gmail.com>
JumasJM
pushed a commit
to FRINXio/conductor-community
that referenced
this pull request
Nov 6, 2023
* Not storing duplicate data in external storage Signed-off-by: Simon Misencik <simon.misencik@gmail.com> * Add dependencies Signed-off-by: Simon Misencik <simon.misencik@gmail.com> --------- Signed-off-by: Simon Misencik <simon.misencik@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Simon Misencik simon.misencik@gmail.com
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
Discussion: Netflix/conductor#3384
This PR implements calculating digest(sha-256) from payloadBytes. This digest is used as an id for record in the database. However, if the same digest/id is already in the database, it only updates the create_at data to prevent deletion during the cleaning of old data.
Alternatives considered
Describe alternative implementation you have considered