This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLock
to refresh dependencies)Changes in this PR
Currently when using the es7-persistence index plugin no workflows will be returned from the search since the query to Elasticsearch isn't correct for ES7 and contains the deprecated
_type
field in the request URI.See also: https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html
Before the change the workflow query will be build something like:
After the change, the URL looks like:
The Elasticsearch _search API still supports the
_types
but when indexing new objects the providedtype
can no longer be defined and will be ignored. All newly added documents do have the type_doc
now and no longerworkflow
.This change should be backwards compatible to existing documents when upgrading from ES6 to ES7.
I also added the plugin to the
gradle.build
file and fixed the corresponding lock files as well. In my case it has worked to still include the upstreames6-persistence
plugin as well thees7-persistence
plugin.