This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Add redis-lock dep #2484
Merged
Add redis-lock dep #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravindanr
approved these changes
Sep 27, 2021
|
@marcocrasso Thanks for the PR. This is an oversight when we moved from |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
This PR adds redis-lock to server's dependencies. Our team is using distributed lock implemented by redis-lock on top of AWS Redis. Since redis-lock has not been listed in the dependencies we are patching upstream on every build. I believe you could add this PR to main branch since default configuration is:
Please review and let me know if anything else should be added or done differently to get this merged.
Thanks in advance!