This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Empty variable is defaulted to empty string #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eplacement can fail the decide process and leave the workflow in a RUNNING state indefinitely
jxu-nflx
reviewed
Oct 4, 2021
| @@ -203,12 +204,18 @@ private Object replaceList(List<?> values, String taskId, DocumentContext io) { | |||
| } | |||
|
|
|||
| private Object replaceVariables(String paramString, DocumentContext documentContext, String taskId) { | |||
| String[] values = paramString.split("(?=(?<!\\$)\\$\\{)|(?<=\\})"); | |||
| String[] values = paramString.split("(?=(?<!\\$)\\$\\{)|(?<=})"); | |||
There was a problem hiding this comment.
Could we add a comment here for the regex?
There was a problem hiding this comment.
That would have been helpful. The original author did not include a comment, i merely removed the redundant escape character.
jxu-nflx
approved these changes
Oct 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors during variable replacement can fail the decide process and leave the workflow in a RUNNING state indefinitely
Pull Request type
Changes in this PR
ParametersUtils defaults
${}or${ }to empty string.