Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Add event handler operations to client #2502

Merged
merged 2 commits into from
Oct 7, 2021

Conversation

jxu-nflx
Copy link
Contributor

@jxu-nflx jxu-nflx commented Oct 6, 2021

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

Added event handler CRUD operations for both http and grpc client.

Alternatives considered

Describe alternative implementation you have considered

@jxu-nflx jxu-nflx added the type: feature New feature label Oct 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Unit Test Results

   156 files  +  2     156 suites  +2   8m 32s ⏱️ +15s
1 142 tests +10  1 142 ✔️ +10  0 💤 ±0  0 ±0 

Results for commit d79c212. ± Comparison against base commit ef6b65d.

♻️ This comment has been updated with latest results.

@@ -294,7 +294,7 @@ private void handleUniformInterfaceException(UniformInterfaceException exception
return;
}
String errorMessage = clientResponse.getEntity(String.class);
LOGGER.error(
LOGGER.warn(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

@aravindanr aravindanr merged commit 0af6a11 into main Oct 7, 2021
@aravindanr aravindanr deleted the jxu/feature/auto-register-eventhandler branch October 7, 2021 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants