Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Fixes #2565 - Fix the broken inline task implementation. Added unit tests for Inline task #2566

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

boney9
Copy link
Contributor

@boney9 boney9 commented Nov 9, 2021

Fix the broken inline task implementation. Added unit tests to validate for both value param and javascript evaluators

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Changes in this PR

Fixes the Inline task validation implementation. Without this fix, inline task won't work.

Issue #2565

Alternatives considered

None

…ests to validate for both value param and javascript evaluators
Copy link

@jeu3nohup jeu3nohup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boney9
Copy link
Contributor Author

boney9 commented Nov 9, 2021

@aravindanr @peterlau - We found this bug and fixed it. FYI.

@aravindanr aravindanr merged commit 461a584 into Netflix:main Nov 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants