This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
task summary ui #3028
Merged
task summary ui #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxu-nflx
force-pushed
the
fix/scheduledtask_workerid
branch
from
a0938a1 to
d01156c
Compare
jxu-nflx
force-pushed
the
fix/scheduledtask_workerid
branch
from
d01156c to
824caaf
Compare
apanicker-nflx
approved these changes
Jun 3, 2022
aravindanr
approved these changes
Jun 6, 2022
v1r3n
added a commit
to orkes-io/conductor
that referenced
this pull request
Jun 24, 2022
* Fix docsite description (for SEO) * Introducing RequestHandler which encapsulates all HTTP operations. The JerseyRequestHandler is an implementation that uses the Jersey client. * removed usages of Guava * Typo fix (Netflix#3029) * task summary ui (Netflix#3028) * Add tests for updateTask * Add callbackAfterSeconds and pollCount in the Task Summary tab * additional constructors in JerseyRequestHandler to simplify its creation * updated reminder about formatting * Replace old logo asset with new logo * Raise max results per page to 1000 * [UI] Separate workflowDefs from latestWorkflowDefs. Reuse existing react-query hooks wherever possible. * [UI] Refactor task related data hooks. * Replace workflow-by-task search with simple task search. * Separate fetchers for poll data and queue size * [UI] Support terminate with reason in Actions & Bulk Actions * [UI] Search for Tasks directly * [UI] Refactor Task Poll Data page to correctly account for domains. * Add a Poll Data tab to task panel * [UI] Fix duration formatting * [UI] Update views to use refactored workflow data hooks and Dropdowns * [UI] Refactor Do-while loops * [UI] Use new logo in AppLogo * improve performance of checkForWorkflowCompletion * sdk documentation additions (Netflix#3047) * sdk documentation additions * csharp update * Bugfix/jointask output (Netflix#3055) * re-throw TerminateWorkflowException for task update * Add only non-empty task output for Join * decider changes * fixes * Update build.gradle * updates * terminate * Update ForkJoinDynamicTaskMapper.java * Update SwitchTaskMapper.java * more changes * disable tests (temp) * formatting Co-authored-by: peterlau <petercslau@gmail.com> Co-authored-by: Aravindan Ramkumar <1028385+aravindanr@users.noreply.github.com> Co-authored-by: Aaron Felkai <31866482+AFelkai@users.noreply.github.com> Co-authored-by: jxu-nflx <90653611+jxu-nflx@users.noreply.github.com> Co-authored-by: Doug Sillars <doug.sillars@gmail.com>
pmchung
pushed a commit
to routific/conductor
that referenced
this pull request
Sep 6, 2023
* Add tests for updateTask * Add callbackAfterSeconds and pollCount in the Task Summary tab
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Please remember to run
./gradlew :conductor-java-sdk:spotlessApplyto fix any format violations.Changes in this PR
Add callbackAfterSeconds and pollCount in the task summary tab
Describe the new behavior from this PR, and why it's needed
Issue #
When worker updates task without completing it, the task is put back in queue for future poll. However, the workerId isn't reset, which makes it confusing as it appears to look like the task is still being processed by that worker. Adding callbackAfterSeconds and pollCount in the task summary tab to make it clear that the woerkerid just shows the instance that last processed the task
Alternatives considered
Describe alternative implementation you have considered