This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Improve message for payload size threshold calculation #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1r3n
approved these changes
Jun 30, 2022
pmchung
pushed a commit
to routific/conductor
that referenced
this pull request
Sep 6, 2023
Co-authored-by: Flávio Schuindt <flavio.schuindt@ge.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #
When we reach the input or output limit for task and workflow the current code returns the limit as the value configured by the user in the properties file which is in Kilobytes. This causes confusion because the actual size calculation is in bytes, so, in the end, we end up in a situation where we are comparing two different units. Also, for the particular message of the workflow limit the word output was being used for both scenarios: inpiut limit and output limit. Therefore, this PR also tries to address it by making the message generic for both cases.
cc: @v1r3n
Alternatives considered
Describe alternative implementation you have considered