This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Fix a subworkflow performance issue without selecting tasks #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxu-nflx
previously approved these changes
Aug 8, 2022
jxu-nflx
reviewed
Aug 8, 2022
core/src/main/java/com/netflix/conductor/core/execution/tasks/SubWorkflow.java
Outdated
Show resolved
Hide resolved
jxu-nflx
reviewed
Aug 8, 2022
| @@ -52,6 +52,8 @@ class AsyncSystemTaskExecutorTest extends Specification { | |||
| workflowExecutor = Mock(WorkflowExecutor.class) | |||
|
|
|||
| workflowSystemTask = Mock(WorkflowSystemTask.class) | |||
| then: | |||
| workflowSystemTask.isTaskRetrievalRequired() >> true | |||
There was a problem hiding this comment.
workflowSystemTask = Mock(WorkflowSystemTask.class) { isTaskRetrievalRequired() >> true }
jxu-nflx
approved these changes
Aug 8, 2022
apanicker-nflx
approved these changes
Aug 9, 2022
6 tasks
pmchung
pushed a commit
to routific/conductor
that referenced
this pull request
Sep 6, 2023
…3152) * Try fixing subworkflow performance issue * Running spotless apply on conductor core * Revert "Running spotless apply on conductor core" This reverts commit b5ebd43. * apply spotless java 11 * fix unit tests * Try to log some info * Revert "Try to log some info" This reverts commit 3411f5d. * See if this change fixes the broken test * Try again
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
Describe the new behavior from this PR, and why it's needed
This plays it extremely safe for now, but other SystemTasks might be able to take advantage of this as well. The only SystemTask that I think needs the tasks pulled in is the DO WHILE. But for now, the subworkflow benefits greatly by not selecting all the tasks (it doesnt need them at this point).