This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Failed task names #3185
Merged
Failed task names #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanicker-nflx
approved these changes
Aug 17, 2022
| @@ -319,8 +322,16 @@ public Set<String> getFailedReferenceTaskNames() { | |||
| return failedReferenceTaskNames; | |||
| } | |||
|
|
|||
| public void setFailedReferenceTaskNames(Set<String> failedReferenceTaskNames) { | |||
| this.failedReferenceTaskNames = failedReferenceTaskNames; | |||
| public void setFailedReferenceTaskNames(Set<String> failedTaskNames) { | |||
There was a problem hiding this comment.
nit: Is this variable name change really needed? I feel that the original retains readability.
There was a problem hiding this comment.
Good catch. That's a benign but unintended global search-n-replace error.
jxu-nflx
approved these changes
Aug 17, 2022
pmchung
pushed a commit
to routific/conductor
that referenced
this pull request
Sep 6, 2023
* Add support for tracking failed task names with workflow execution * Fix tests * Undo inadvertent variable name change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Add field
failedTaskNamestoWorkflowandWorkflowSummary, to be indexed in ES enabling workflows to be queried for by the TaskDef names of the failed tasks.Alternatives considered
Modifying