This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Split event system task implementation between start and execute #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanicker-nflx
force-pushed
the
execute_logic_for_event
branch
from
a5517f4 to
c96e8c6
Compare
jxu-nflx
approved these changes
Aug 18, 2022
manan164
added a commit
to manan164/conductor
that referenced
this pull request
Nov 2, 2022
…ute (Netflix#3187)" This reverts commit 8b62e35
1 task
pmchung
pushed a commit
to routific/conductor
that referenced
this pull request
Sep 6, 2023
…flix#3187) * event system task implementation is split between start and execute * added integ test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Fixes a race condition where a COMPLETED asyncComplete event task could move back to IN_PROGRESS if task update is received before task creation occurs.