This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Fix next task not scheduled after switch completes #3197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanicker-nflx
approved these changes
Aug 23, 2022
jxu-nflx
force-pushed
the
bugfix/workflow_hanging_after_switch_task
branch
from
f3ef76e to
531714e
Compare
manan164
reviewed
Aug 24, 2022
| @@ -96,8 +96,7 @@ public List<TaskModel> getMappedTasks(TaskMapperContext taskMapperContext) { | |||
| switchTask.getInputData().put("case", evalResult); | |||
| switchTask.getOutputData().put("evaluationResult", Collections.singletonList(evalResult)); | |||
| switchTask.setStartTime(System.currentTimeMillis()); | |||
| switchTask.setStatus(TaskModel.Status.COMPLETED); | |||
| switchTask.setExecuted(true); | |||
| switchTask.setStatus(TaskModel.Status.IN_PROGRESS); | |||
There was a problem hiding this comment.
The switch task is completed here so the status should be COMPLETED .Only executed flag has to be removed.
There was a problem hiding this comment.
It will be marked as completed in the executor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Revert changes done to SwitchTaskMapper introduced by this PR, and add test case to verify the fix.
Describe the new behavior from this PR, and why it's needed
Issue #
#3089 (comment)
Alternatives considered
Describe alternative implementation you have considered