This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Ensure that JOIN tasks wait for all retries before terminating #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bjpirt , Changes look fine. Can you please write few tests around this change? |
v1r3n
reviewed
Jun 8, 2023
| @@ -56,15 +56,19 @@ public boolean execute( | |||
| break; | |||
| } | |||
| TaskModel.Status taskStatus = forkedTask.getStatus(); | |||
| hasFailures = !taskStatus.isSuccessful() && !forkedTask.getWorkflowTask().isOptional(); | |||
| hasFailures = | |||
There was a problem hiding this comment.
the code at line 52 should already fetch the join task that is retried, so it will be in progress and will wait for it to complete.
manan164
reviewed
Jun 14, 2023
| @JsonIgnore | ||
| public boolean isStillInNeedOfProcessing() { | ||
| if (Status.FAILED.equals(getStatus())) { | ||
| final int taskDefRetryCount = getTaskDefinition().map(TaskDef::getRetryCount).orElse(0); |
There was a problem hiding this comment.
This can create NPE when task definition is not present.
1 task
|
Closing in favour of #3655 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credit to @james-deee who authored the patch that this PR implements.
This fixes the bug where a JOIN wasn't waiting for all of the retries for a task to have been performed
Pull Request type
Changes in this PR
This fixes the bug where a JOIN wasn't waiting for all of the retries for a task to have been performed